With armed conflicts spreading, investors’ enthusiasm for arms suppliers is understandable. Yet it comes with risks