A pop-up store selling empty crisp packets, odd socks and used biros would do a roaring trade in today’s Leith, says Stephen Jardine