The number of American millionaires has reached a record high, but rising costs are chipping away at the value of nest eggs.