Buying a home in New York City will cost the average resident the better part of their adult life — in savings time, at least.